chore: remove copy_file in oci_tar #8802
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
added
the
CI_ALL_BAZEL_TARGETS
cgundy
approved these changes
Feb 12, 2026
Base automatically changed from
basvandijk/refactor-uvm_config_image
to
master
February 12, 2026 12:28
basvandijk
added a commit
that referenced
this pull request
Feb 12, 2026
… remap_paths (#8796) Besides being a requirement for: #8802 it's better to be fully explicit about how source files are mapped into FAT images in the `mcopy` and `uvm_config_image` rules. So this replaces their `srcs` and `remap_paths` arguments with the single `srcmap` argument of type `label_keyed_string_dict` that specifies how a source target is mapped into the FAT image.
andrewbattat
approved these changes
Feb 12, 2026
basvandijk
removed
the
CI_ALL_BAZEL_TARGETS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like the Ubuntu
@noble//...packages and everything that depends on them to be only compatible with Linux such that they're not build on MacOS.Now, even though the
copy_filerule inoci_taris configured withtarget_compatible_with = [ "@platforms//os:linux"]it seems like that property is not taken into account:It turns out we don't really need that
copy_filerule anyway so this commit removes it resulting in:Also note that
rules_ocirecommends not depending onoci_loadoutputs if it can be avoided since it will trash the cache:https://github.com/bazel-contrib/rules_oci/blob/main/docs/load.md#build-outputs